szehon-ho commented on code in PR #15726:
URL: https://github.com/apache/iceberg/pull/15726#discussion_r2977884207
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
##########
@@ -343,6 +343,57 @@ public void testRowLineageColumnsResolvedInV3OrHigher() {
}
}
+ /**
+ * Regression test for a NPE in PruneColumns.isStruct() caused by a
_partition child field ID
Review Comment:
nit: i would probably not say 'doesNotNPE' in the test name,
and also just skip 'Regression Test' in the test description. I think both
are obvious and doesnt add value.
How about: and skip the comment?
testPartitionMetadataColumnWithMapColumn()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
