blackmwk commented on code in PR #2280:
URL: https://github.com/apache/iceberg-rust/pull/2280#discussion_r2985254720
##########
crates/iceberg/testdata/example_table_metadata_v1.json:
##########
Review Comment:
There is a dir `table_metadata` under `testdata`, and we should move it to
that dir. We also should rename it to `TableMetadataV1SnapshotNoSchemaId`
##########
crates/iceberg/src/io/object_cache.rs:
##########
@@ -406,4 +408,106 @@ mod tests {
"1.parquet"
);
}
+
+ /// Regression test: ObjectCache::get_manifest_list must not panic when
+ /// the snapshot has no schema_id (Iceberg v1 format tables).
+ #[tokio::test]
+ async fn test_get_manifest_list_v1_snapshot_without_schema_id() {
+ let tmp_dir = TempDir::new().unwrap();
Review Comment:
There are example above to use TestTableFixture to simplify the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
