Guosmilesmile commented on code in PR #15675:
URL: https://github.com/apache/iceberg/pull/15675#discussion_r2987689105
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -719,4 +1205,15 @@ private static String splitSizeProperty(FileFormat
fileFormat) {
"No split size property defined for format: " + fileFormat);
};
}
+
+ private Map<Integer, Object> convertConstantsToEngine(
Review Comment:
I found the reason why this part is so complicated. It happens on the Flink
side where `RowDataConverter.convert` used in `convertToEngine` will force the
STRUCT to be converted to a `Record`. While `SparkUtil.internalToSpark` has
handled this case. Since `RowDataConverter` is production code, I added
handling for `PartitionData` in `TestFlinkFormatModel`'s
`convertConstantToEngine`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
