kevinjqliu commented on PR #3124: URL: https://github.com/apache/iceberg-python/pull/3124#issuecomment-4130455208
Thanks for the details @EnyMan great to see you guys are already running that in production! I see https://github.com/EnyMan/iceberg-python/pull/2, we can use that as a reference for future implementation 😄 For `REPLACE` vs `OVERWRITE`, `replace` an optimization as described above. Its guaranteeing that no data is changed, only metadata and metadata structure. I think iceberg-go is using `OVERWRITE` for its compaction path. But we should use `replace` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
