RussellSpitzer commented on code in PR #15634:
URL: https://github.com/apache/iceberg/pull/15634#discussion_r2996102092


##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -154,6 +154,12 @@ private <T extends ContentFile<T>> PartitionSpec 
readPartitionSpec(InputFile inp
   }
 
   private static <T extends ContentFile<T>> Map<String, String> 
readMetadata(InputFile inputFile) {
+    FileFormat manifestFormat = FileFormat.fromFileName(inputFile.location());
+    Preconditions.checkArgument(
+        manifestFormat == FileFormat.AVRO,
+        "Reading manifest metadata is only supported for Avro manifests: %s",

Review Comment:
   Now that I fixed all the tests, there is no code inside the Iceberg project 
that relies on this code path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to