rambleraptor commented on code in PR #15655:
URL: https://github.com/apache/iceberg/pull/15655#discussion_r2997805657
##########
build.gradle:
##########
@@ -705,10 +706,10 @@ project(':iceberg-bigquery') {
implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
- implementation platform(libs.google.libraries.bom)
+ compileOnly platform(libs.google.libraries.bom)
compileOnly "com.google.cloud:google-cloud-storage"
- implementation "com.google.cloud:google-cloud-bigquery"
- implementation "com.google.cloud:google-cloud-core"
+ compileOnly "com.google.cloud:google-cloud-bigquery"
+ compileOnly "com.google.cloud:google-cloud-core"
Review Comment:
I did some sanity testing:
- Ran Spark with `iceberg-bigquery,iceberg-spark-runtime` to query a
BigQuery table. This failed since it required dependencies from
`iceberg-gcp-bundle` (for authentication / others).
- Ran Spark with
`iceberg-bigquery,iceberg-spark-runtime,iceberg-gcp-bundle`. Worked as expected.
This is telling me the bundles are taking on the dependencies we expect them
to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
