huaxingao commented on code in PR #15757: URL: https://github.com/apache/iceberg/pull/15757#discussion_r2997747425
########## .github/workflows/zizmor.yml: ########## @@ -0,0 +1,68 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Zizmor Workflow Audit" +on: + pull_request: + paths: + - '.github/workflows/**' + +permissions: + contents: read + +jobs: + zizmor: + runs-on: ubuntu-24.04 + steps: + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 + - uses: astral-sh/setup-uv@0c5e2b8115b80b4c7c5ddf6ffdd634974642d182 # v5 + - name: Run zizmor audit + # Runs zizmor (https://docs.zizmor.sh/) in offline mode to detect + # unpinned third-party actions. Actions referenced by mutable tag + # (e.g. `actions/checkout@v4`) can be silently replaced by a + # compromised or force-pushed tag, allowing arbitrary code execution + # in CI. Pinning to a full commit SHA makes the reference immutable. + run: | + findings=$(uvx --from zizmor zizmor \ + --offline \ + --format json-v1 \ + .github/workflows 2>/dev/null \ Review Comment: Nit: `2>/dev/null` hides errors, if zizmor fails to run, `$findings` will be empty and the check will silently pass. Maybe remove it or check the exit code first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
