rambleraptor commented on code in PR #15746:
URL: https://github.com/apache/iceberg/pull/15746#discussion_r3002627344
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -162,6 +162,8 @@ paths:
$ref: '#/components/responses/UnauthorizedResponse'
403:
$ref: '#/components/responses/ForbiddenResponse'
+ 404:
+ $ref: '#/components/responses/NoSuchWarehouseResponse'
Review Comment:
I don't think `204` is the proper way to go. The 4xx HTTP codes are meant to
indicate client error. The client gave a warehouse that doesn't exist, which is
a form of user error.
204 would mean that the warehouse exists and that the config has no data.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -162,6 +162,8 @@ paths:
$ref: '#/components/responses/UnauthorizedResponse'
403:
$ref: '#/components/responses/ForbiddenResponse'
+ 404:
+ $ref: '#/components/responses/NoSuchWarehouseResponse'
Review Comment:
I don't think `204` is the proper way to go. The 4xx HTTP codes are meant to
indicate client error. The client gave a warehouse that doesn't exist, which is
a form of user error.
204 would mean that the warehouse exists and that the config has no
parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
