thswlsqls opened a new pull request, #15804: URL: https://github.com/apache/iceberg/pull/15804
The 3-arg VectorHolder constructor (FieldVector, NestedField, NullabilityHolder) was package-private but all callers are within the same top-level class (PositionVectorHolder inner class and vectorHolder() factory method). Since Java static inner classes can access private members of the enclosing class, this constructor can safely be made private to reduce its visibility scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
