dttung2905 commented on code in PR #16: URL: https://github.com/apache/iceberg-terraform/pull/16#discussion_r3005293537
########## internal/provider/polaris_client.go: ########## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package provider + +import ( + "bytes" + "context" + "encoding/json" + "errors" + "fmt" + "io" + "net/http" + "net/url" + "path" +) + +type polarisClient struct { + baseURL *url.URL + httpClient *http.Client + token string + headers map[string]string +} Review Comment: Hi @zeroshade , Polaris does indeed implement the Iceberg REST catalog API, and we use iceberg-go’s REST catalog client for normal catalog operations via catalog_uri. The iceberg_polaris_principal resource targets Polaris’s Management API (/api/management/v1/...), which is outside the Iceberg REST catalog spec. iceberg-go’s REST catalog client doesn’t cover those endpoints, so we keep a small HTTP client for management calls while reusing the same provider token/headers where appropriate. Happy to rename or document this more clearly if that helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
