kevinjqliu commented on code in PR #15820:
URL: https://github.com/apache/iceberg/pull/15820#discussion_r3006743168
##########
.github/workflows/codeql.yml:
##########
@@ -46,11 +46,11 @@ jobs:
persist-credentials: false
- name: Initialize CodeQL
- uses: github/codeql-action/init@38697555549f1db7851b81482ff19f1fa5c4fedc
# v4
+ uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13
# v4
Review Comment:
https://github.com/github/codeql-action/commit/c10b8064de6f491fea524254123dbe5e09572f13
##########
.github/workflows/zizmor.yml:
##########
@@ -41,3 +40,5 @@ jobs:
- name: Run zizmor 🌈
uses:
zizmorcore/zizmor-action@71321a20a9ded102f6e9ce5718a2fcec2c4f70d8 # v0.5.2
+ with:
Review Comment:
by default, zizmor's `advanced-security` feature is on which will upload to
the "security" tab, but wont error in CI.
https://github.com/zizmorcore/zizmor-action?tab=readme-ov-file#changes-introduce-security-alerts-but-no-pr-checks-are-shown
We actually want the CI check to error, so we need to turn
`advanced-security` off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
