hcrosse opened a new pull request, #825: URL: https://github.com/apache/iceberg-go/pull/825
`positionDeleteRecordsToDataFiles` calls `iter.Pull(args.counter)` unconditionally, but in the partitioned path `newWriterFactory` creates its own pulled counter and the original `stopCount` is never called. This leaks one goroutine per write - we noticed via pprof after a few hours of steady writes. The fix scopes `iter.Pull` to the unpartitioned branch where it's actually used, same as `equality_delete_writer.go`. The partitioned path gets its own counter through `newWriterFactory`. Added a regression test that calls the partitioned path 50 times and checks goroutine count doesn't grow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
