emkornfield commented on code in PR #2288:
URL: https://github.com/apache/iceberg-rust/pull/2288#discussion_r3012397248
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -3618,7 +3618,7 @@ mod tests {
let original_metadata: TableMetadata =
get_test_table_metadata("TableMetadataV2Valid.json");
let json = serde_json::to_string(&original_metadata).unwrap();
- let compressed = CompressionCodec::Gzip
+ let compressed = CompressionCodec::Gzip(None)
Review Comment:
9 I think is max decompression level, 6 (is the default
https://docs.rs/flate2/latest/src/flate2/lib.rs.html#251), by assigning None
here I think we end up with 6. I'm in the process of changing the code to have
a default constructor without the None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
