CTTY commented on code in PR #2296:
URL: https://github.com/apache/iceberg-rust/pull/2296#discussion_r3012461115
##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -175,10 +177,15 @@ impl<'a> SnapshotProducer<'a> {
let manifest_list = current_snapshot
.load_manifest_list(self.table.file_io(),
&self.table.metadata_ref())
.await?;
- for manifest_list_entry in manifest_list.entries() {
- let manifest = manifest_list_entry
- .load_manifest(self.table.file_io())
- .await?;
+
+ let file_io = self.table.file_io();
+ let mut manifest_futures: FuturesUnordered<_> = manifest_list
+ .entries()
+ .iter()
+ .map(|entry| entry.load_manifest(file_io))
+ .collect();
Review Comment:
Should we `buffer_unordered` here? This is an IO operation and too many
requests may overwhelm the storage backend
`.buffer_unordered(32)` should make the most object stores happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
