RussellSpitzer commented on code in PR #15822: URL: https://github.com/apache/iceberg/pull/15822#discussion_r3013140428
########## AGENTS.md: ########## @@ -159,6 +159,7 @@ The `api/` module has the strongest stability guarantees — breaking changes ar - One concern per PR. Unrelated whitespace, import, or formatting changes go in separate PRs. - Keep first version of a PR minimal — defer recovery, optimization, and edge cases to follow-ups. - Commit messages describe the *what* and *why*, not implementation details. +- Before creating or amending a commit, run the relevant code style check and fix any violations. Review Comment: It works with pre-commit, we could add it to the repo but you would still need to install pre-commit first. I thought folks may be more opinionated about their env, so I didn't add it to the repo. It's very easy to setup though, and once you do, every time you commit it just gets in the way, runs spotless, stages and commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
