geruh commented on code in PR #3215: URL: https://github.com/apache/iceberg-python/pull/3215#discussion_r3017008337
########## .github/workflows/nightly-pypi-build.yml: ########## @@ -29,7 +29,7 @@ permissions: jobs: set-version: - if: github.repository == 'apache/iceberg-python' # Only run for apache repo + if: github.repository == 'apache/iceberg-python' || github.event_name == 'workflow_dispatch' Review Comment: nit: Now that `set-version` allows `workflow_dispatch` from any repo, the original comment explaining the intent is gone. Worth adding something like `# Run on schedule for apache repo, or on manual dispatch from any repo` so the asymmetry is clear to future readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
