rchowell opened a new pull request, #2311: URL: https://github.com/apache/iceberg-rust/pull/2311
## Which issue does this PR close? - Closes #1236 ## What changes are included in this PR? - Creates a new `signing` mod inside the `rest` mod. - Adds a `HttpRequestSigner` trait for signing headers. - Adds an AWS SigV4 implementation with patched URL handling ## Are these changes tested? - New unit tests for URL encoding - Manual verification against S3 Tables Iceberg REST endpoint. ## Additional Context There are several PRs in this space, and I did my best to consolidate them all into this. (1) https://github.com/apache/iceberg-rust/pull/917 This is the first and @phillipleblanc suggested an implementation without the aws crates. (2) https://github.com/apache/iceberg-rust/pull/1241 This is the reqwest approach, but @xxchan found a bug in url encoding. It uses reqsign-aws-v4. (3) https://github.com/apache/iceberg-rust/pull/2088 This is a nice approach for more general auth, and it may be best to have a discussion on the design so that a large PR like this is reviewable. This new PR is intentionally smaller in scope to hopefully close at #1236. (4) https://github.com/mdub/iceberg-rust/commit/440053990e1d474a0a8a0a53878d1870f69eba93 Credit to @mdub here which was the latest reference on the issue. It's a reqwest-based approach. I've adapted this based on the discussions in (1) and (2). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
