jackylee-ch opened a new pull request, #15879:
URL: https://github.com/apache/iceberg/pull/15879

   ## Summary
   
     - Fix NPE in `ParquetWriteAdapter.length()` and `splitOffsets()` when 
called after `close()` by caching data size and reusing cached footer before 
nullifying the internal writer
     - Add regression tests verifying the `FileAppender` post-close contract 
for the deprecated adapter
     - Clean up the pre-close `length()` workaround in 
`ParquetWritingTestUtils` that was needed because of this bug
   
     Fixes #14310
   
     ## Test Plan
   
     - [x] `TestParquetWriteAdapter.postCloseAccessors` — verifies `length()`, 
`metrics()`, `splitOffsets()` work after close
     - [x] `TestParquetWriteAdapter.dataWriterCloseWithDeprecatedAdapter` — 
end-to-end `DataWriter.close()` path
     - [x] Full `:iceberg-parquet:test` suite — 642 tests pass, 0 failures


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to