RussellSpitzer commented on code in PR #15676:
URL: https://github.com/apache/iceberg/pull/15676#discussion_r3033410403
##########
baseline.gradle:
##########
@@ -187,6 +187,21 @@ subprojects {
}
pluginManager.withPlugin('scala') {
+ apply plugin: 'io.github.cosmicsilence.scalafix'
+
+ scalafix {
+ configFile = file("${rootDir}/.baseline/scala/.scalafix.conf")
+ semanticdb {
+ autoConfigure = true
+ }
+ }
+
+ // When running scalafix, downgrade unused import errors to warnings so
that
+ // compilation succeeds and SemanticDB is produced for Scalafix to process.
+ boolean scalafixRun = gradle.startParameter.taskNames.any {
Review Comment:
I think we are better off just not adding anything to the build, I've grown
very paranoid of adding things to the build with all the supply chain attacks
lately and even though I think this would be relatively safe, I don't think we
really gain that much by giving folks an auto fix command. We aren't really a
scala project so the benefits here feel very low compared to adding complexity
to the build and a new plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
