shangxinli commented on code in PR #592:
URL: https://github.com/apache/iceberg-cpp/pull/592#discussion_r3035800762
##########
src/iceberg/update/expire_snapshots.h:
##########
@@ -169,6 +224,14 @@ class ICEBERG_EXPORT ExpireSnapshots : public
PendingUpdate {
enum CleanupLevel cleanup_level_ { CleanupLevel::kAll };
bool clean_expired_metadata_{false};
bool specified_snapshot_id_{false};
+
+ /// Cached result from Apply(), used during Finalize() for file cleanup
+ std::optional<ApplyResult> apply_result_;
+
+ /// Cache of manifest path -> ManifestFile, built during
ReadManifestsForSnapshot
+ /// to avoid O(M*S) repeated I/O from re-reading manifest lists in
+ /// FindDataFilesToDelete.
+ std::unordered_map<std::string, ManifestFile> manifest_cache_;
Review Comment:
Done — manifest_cache_ is now a private member of ReachableFileCleanup in
expire_snapshots.cc. It no longer appears in the header at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
