ajantha-bhat commented on code in PR #15896:
URL: https://github.com/apache/iceberg/pull/15896#discussion_r3038462646


##########
format/spec.md:
##########
@@ -1007,7 +1007,7 @@ The schema of the partition statistics file is as follows:
 
 | v1 | v2 | v3 | Field id, name | Type | Description |
 |----|----|----|----------------|------|-------------|
-| _required_ | _required_ | _required_ | **`1 partition`** | `struct<..>` | 
Partition data tuple, schema based on the unified partition type considering 
all specs in a table |
+| _required_ | _required_ | _required_ | **`1 partition`** | `struct<..>` | 
Partition data tuple, schema based on the unified partition type considering 
all specs in a table, empty for unpartitioned tables |

Review Comment:
   yes. any spec change has to go for vote. 
   
   And whats the use case? You want to know data files, delete files, file size 
for unpartitioned table? We can use metadata tables for that Or maybe the new 
v4 manifests can solve it (with less I/O)? 
   
   Also, since the name itself is partitions stats. It makes odd to generate 
the file for unpartitioned table. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to