gaborkaszab commented on PR #15903: URL: https://github.com/apache/iceberg/pull/15903#issuecomment-4195280190
cc @singhpk234 It felt more natural to set the client side part of the scan planning mode in the initialize() of the catalog, since it's a startup flag. We could also give an error when we provide an invalid value right away when creating a catalog. Otherwise, a server-side setting of the same would simply hide the invalid setting. Also, in the ScanPlanningMode enum it felt an overkill to have the fromString and modeName functions, because the enumerator itself already has the required functionality for this. Let me know if you disagree and I'll revert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
