anoopj commented on PR #15883: URL: https://github.com/apache/iceberg/pull/15883#issuecomment-4196161070
The change looks reasonable to me. The only callout is the null handling: if there are null values, the implementation will return ROWS_MUST_MATCH for them as well. This doesn't follow SQL's 3-valued semantics, but is consistent with the current implementation of notEq, so I think the change is reasonable. Please get this reviewed by a committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
