zeroshade commented on code in PR #855:
URL: https://github.com/apache/iceberg-go/pull/855#discussion_r3047618923
##########
table/scanner.go:
##########
@@ -555,6 +581,7 @@ type FileScanTask struct {
File iceberg.DataFile
DeleteFiles []iceberg.DataFile // positional delete files
EqualityDeleteFiles []iceberg.DataFile // equality delete files
+ DeletionVectorFiles []iceberg.DataFile // deletion vectors (puffin
files)
Review Comment:
since the actual scanner will ignore these, we should probably also update
the scanner to error if this is non-empty just so people don't think it's
working.
##########
table/scanner.go:
##########
@@ -530,6 +546,15 @@ func (scan *Scan) PlanFiles(ctx context.Context)
([]FileScanTask, error) {
return cmp.Compare(a.SequenceNum(), b.SequenceNum())
})
+ // Index DVs by referenced data file path for O(1) lookup.
+ dvIndex := make(map[string][]iceberg.DataFile, len(entries.dvEntries))
+ for _, del := range entries.dvEntries {
+ ref := del.DataFile().ReferencedDataFile()
+ if ref != nil {
Review Comment:
```suggestion
if ref := del.DataFile().ReferencedDataFile(); ref != nil {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
