anoopj commented on PR #15910: URL: https://github.com/apache/iceberg/pull/15910#issuecomment-4226897983
Thanks for removing the table.io().close() call. That addresses the shared FileIO problem. The remaining change looks correct for broadening metadata table invalidation. But the test `testFileIOClosedOnCacheEviction()` still asserts `close()` in the mock class, which will fail since the close call was removed. I recommend modifying the test to verify the `wasEvicted()` behavior instead (e.g., assert that metadata tables are invalidated for non-EXPIRED eviction causes like `COLLECTED`). Also the PR description still references closing FileIO - you might want to fix that as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
