mxm commented on code in PR #15815:
URL: https://github.com/apache/iceberg/pull/15815#discussion_r3066895737
##########
flink/v1.20/build.gradle:
##########
@@ -71,9 +71,6 @@ project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}") {
testImplementation libs.flink120.connector.test.utils
testImplementation libs.flink120.core
testImplementation libs.flink120.runtime
- testImplementation(libs.flink120.test.utilsjunit) {
- exclude group: 'junit'
- }
testImplementation(libs.flink120.test.utils) {
Review Comment:
Good catch! We could still merge this PR and remove these lines because they
were meant to exclude junit, which didn't work. Regardless, we need to wait on
upstream or copy the relevant upstream files into Iceberg.
##########
flink/v1.20/build.gradle:
##########
@@ -71,9 +71,6 @@ project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}") {
testImplementation libs.flink120.connector.test.utils
testImplementation libs.flink120.core
testImplementation libs.flink120.runtime
- testImplementation(libs.flink120.test.utilsjunit) {
- exclude group: 'junit'
- }
testImplementation(libs.flink120.test.utils) {
Review Comment:
Good catch! We could still merge this PR and remove these lines because they
were meant to exclude junit, which didn't work. Regardless, we need to wait on
upstream or copy the relevant upstream files into Iceberg.
##########
flink/v1.20/build.gradle:
##########
@@ -71,9 +71,6 @@ project(":iceberg-flink:iceberg-flink-${flinkMajorVersion}") {
testImplementation libs.flink120.connector.test.utils
testImplementation libs.flink120.core
testImplementation libs.flink120.runtime
- testImplementation(libs.flink120.test.utilsjunit) {
- exclude group: 'junit'
- }
testImplementation(libs.flink120.test.utils) {
Review Comment:
Good catch! We could still merge this PR and remove these lines because they
were meant to exclude junit, which didn't work. Regardless, we need to wait on
upstream or copy the relevant upstream files into Iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
