nastra commented on code in PR #15939:
URL: https://github.com/apache/iceberg/pull/15939#discussion_r3069034729
##########
api/src/main/java/org/apache/iceberg/stats/FieldStatistic.java:
##########
@@ -125,13 +125,13 @@ public static Types.StructType
fieldStatsFor(Types.NestedField field, int baseFi
baseFieldId + AVG_VALUE_SIZE.offset(),
AVG_VALUE_SIZE.fieldName(),
Types.IntegerType.get(),
- "Avg value size of variable-length types (String, Binary)"));
+ "Avg value size in bytes of variable-length types (String,
Binary)"));
fields.add(
optional(
baseFieldId + MAX_VALUE_SIZE.offset(),
MAX_VALUE_SIZE.fieldName(),
Types.IntegerType.get(),
- "Max value size of variable-length types (String, Binary)"));
+ "Max value size in bytes of variable-length types (String,
Binary)"));
Review Comment:
@singhpk234 apologies, I thought you had a slightly bigger change in mind
(hence why I thought a separate PR is better) but I think we only need
```
- "Avg value size in bytes of variable-length types (String, Binary)"
+ "Avg stored (compressed, encoded) value size in bytes of variable-length
types (String, Binary)"
- "Max value size in bytes of variable-length types (String, Binary)"
+ "Max stored (compressed, encoded) value size in bytes of variable-length
types (String, Binary)"
```
I still have another PR in this area that I wanted to create, so I'll make
sure to include this there, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
