zeroshade commented on code in PR #867:
URL: https://github.com/apache/iceberg-go/pull/867#discussion_r3074333614
##########
table/transaction.go:
##########
@@ -715,7 +709,7 @@ func (t *Transaction) ReplaceDataFilesWithDataFiles(ctx
context.Context, filesTo
}
commitUUID := uuid.New()
- updater := t.updateSnapshot(fs, snapshotProps,
OpOverwrite).mergeOverwrite(&commitUUID)
+ updater := t.updateSnapshot(fs, snapshotProps,
OpReplace).mergeOverwrite(&commitUUID)
Review Comment:
same as above, we should validate that there's no actual data changes before
using OpReplace, right?
##########
table/transaction.go:
##########
@@ -828,7 +822,7 @@ func (t *Transaction) ReplaceFiles(ctx context.Context,
dataFilesToDelete, dataF
}
commitUUID := uuid.New()
- updater := t.updateSnapshot(fs, snapshotProps,
OpOverwrite).mergeOverwrite(&commitUUID)
+ updater := t.updateSnapshot(fs, snapshotProps,
OpReplace).mergeOverwrite(&commitUUID)
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
