alliasgher commented on code in PR #877:
URL: https://github.com/apache/iceberg-go/pull/877#discussion_r3074645455
##########
table/transaction.go:
##########
@@ -220,6 +220,15 @@ func (t *Transaction) ExpireSnapshots(opts
...ExpireSnapshotsOpt) error {
opt(&cfg)
}
+ // Read table-level retention properties as the last-resort defaults,
+ // mirroring the Java implementation. When neither the ref nor the
+ // caller provides a value, fall back to the table property; when the
+ // table property is also absent use the constant default (math.MaxInt,
+ // meaning "keep everything").
Review Comment:
Noted — happy to add a `GetInt64` helper and use it here as a follow-up if
you'd like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
