alliasgher commented on code in PR #878:
URL: https://github.com/apache/iceberg-go/pull/878#discussion_r3074673082
##########
table/internal/parquet_files_test.go:
##########
@@ -691,6 +691,33 @@ func TestGetWritePropertiesPageVersion(t *testing.T) {
}
}
+func TestGetWritePropertiesBloomFilter(t *testing.T) {
+ format := internal.GetFileFormat(iceberg.ParquetFile)
+
+ t.Run("default max bloom filter bytes", func(t *testing.T) {
+ wp :=
parquet.NewWriterProperties(format.GetWriteProperties(iceberg.Properties{}).([]parquet.WriterProperty)...)
+ assert.Equal(t,
int64(internal.ParquetBloomFilterMaxBytesDefault), wp.MaxBloomFilterBytes())
+ })
+
+ t.Run("custom max bloom filter bytes", func(t *testing.T) {
+ props := iceberg.Properties{
+ internal.ParquetBloomFilterMaxBytesKey: "2097152",
+ }
+ wp :=
parquet.NewWriterProperties(format.GetWriteProperties(props).([]parquet.WriterProperty)...)
+ assert.Equal(t, int64(2097152), wp.MaxBloomFilterBytes())
+ })
+
+ t.Run("per-column bloom filter enabled", func(t *testing.T) {
+ props := iceberg.Properties{
+ internal.ParquetBloomFilterColumnEnabledKeyPrefix +
".id": "true",
+ internal.ParquetBloomFilterColumnEnabledKeyPrefix +
".name": "false",
+ }
+ wp :=
parquet.NewWriterProperties(format.GetWriteProperties(props).([]parquet.WriterProperty)...)
+ assert.True(t, wp.BloomFilterEnabledFor("id"))
Review Comment:
Added in 9684d10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
