dhruvarya-db commented on code in PR #15960:
URL: https://github.com/apache/iceberg/pull/15960#discussion_r3075683825
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -450,6 +450,11 @@
<property name="format"
value="^\s*(public\s+)?(abstract\s+)?class\s+[A-Za-z0-9]*Test(\s|<)"/>
<property name="message" value="Test class names should start with
'Test' prefix, not end with 'Test' suffix. Example: 'TestNewFeature' instead of
'NewFeatureTest'"/>
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="id" value="BanCaseConversionWithoutLocale"/>
Review Comment:
[nit] would it make sense to add `<property name="ignoreComments"
value="true"/>` here so that String::toLowerCase() usage in comments is ignored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
