RussellSpitzer commented on code in PR #15967:
URL: https://github.com/apache/iceberg/pull/15967#discussion_r3076382881
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -402,21 +402,22 @@ private void checkAndAddPartitionName(String name,
Integer sourceColumnId) {
Types.NestedField schemaField =
this.caseSensitive ? schema.findField(name) :
schema.caseInsensitiveFindField(name);
if (checkConflicts) {
- if (sourceColumnId != null) {
Review Comment:
I flipped this around because I kept getting confused now its
1. Normal case, no source id
2. Checking for partition transforms with source id (like identity)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
