rdblue commented on code in PR #15854: URL: https://github.com/apache/iceberg/pull/15854#discussion_r3082146673
########## core/src/main/java/org/apache/iceberg/TrackedFileStruct.java: ########## @@ -0,0 +1,729 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.nio.ByteBuffer; +import java.util.List; +import java.util.Set; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.stats.BaseContentStats; +import org.apache.iceberg.stats.ContentStats; +import org.apache.iceberg.types.Types; +import org.apache.iceberg.util.ByteBuffers; + +/** Mutable {@link StructLike} implementation of {@link TrackedFile}. */ +class TrackedFileStruct implements TrackedFile, StructLike { + private static final FileContent[] FILE_CONTENT_VALUES = FileContent.values(); + private static final EntryStatus[] STATUS_VALUES = EntryStatus.values(); + + private TrackingStruct tracking; + private int contentType; + private String location; + private String fileFormat; + private long recordCount; + private long fileSizeInBytes; + private Integer specId; + private ContentStats contentStats; + private Integer sortOrderId; + private DeletionVectorStruct deletionVector; + private ManifestInfoStruct manifestInfo; + private ByteBuffer keyMetadata; + private List<Long> splitOffsets; Review Comment: Classes like this typically use arrays instead of lists because arrays are compatible with both Java and Kryo serialization. Our best practice is to use arrays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
