geruh commented on code in PR #3237:
URL: https://github.com/apache/iceberg-python/pull/3237#discussion_r3083660406
##########
tests/integration/test_deletes.py:
##########
@@ -975,3 +975,58 @@ def assert_manifest_entry(expected_status:
ManifestEntryStatus, expected_snapsho
assert after_delete_snapshot is not None
assert_manifest_entry(ManifestEntryStatus.DELETED,
after_delete_snapshot.snapshot_id)
+
+
[email protected]
+def test_manifest_entry_snapshot_id_after_partial_deletes(session_catalog:
RestCatalog) -> None:
+ """Test that DELETED manifest entries from a CoW overwrite (partial
delete) have the correct snapshot_id.
Review Comment:
Nit: I think we can drop the doc string comment here and rely on the test
logic and commit history. The commit already references the issue so we should
be good!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
