geruh commented on code in PR #3121:
URL: https://github.com/apache/iceberg-python/pull/3121#discussion_r3083858123
##########
pyiceberg/catalog/hive.py:
##########
@@ -135,9 +133,16 @@
DEFAULT_LOCK_CHECK_MIN_WAIT_TIME = 0.1 # 100 milliseconds
DEFAULT_LOCK_CHECK_MAX_WAIT_TIME = 60 # 1 min
DEFAULT_LOCK_CHECK_RETRIES = 4
+
Review Comment:
nit: do we need to add these new lines?
##########
pyiceberg/catalog/hive.py:
##########
@@ -499,6 +499,109 @@ def _do_wait_for_lock() -> LockResponse:
return _do_wait_for_lock()
+ def _do_commit(
Review Comment:
still looks like we have a lot of noise here :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
