kevinjqliu commented on code in PR #34:
URL: https://github.com/apache/iceberg-terraform/pull/34#discussion_r3088842860
##########
.github/workflows/go-ci.yml:
##########
@@ -42,19 +42,21 @@ jobs:
go: [ '1.23.6', '1.24.9' ,'1.25.1']
os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest' ]
steps:
- - uses: actions/checkout@v6
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+ with:
+ persist-credentials: false
- name: Install Go
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
with:
go-version: ${{ matrix.go }}
- cache: true
+ cache: false
cache-dependency-path: go.sum
- name: Install staticcheck
run: GOTOOLCHAIN='go1.24.9' go install
honnef.co/go/tools/cmd/[email protected]
- name: Run golangci-lint
- uses: golangci/golangci-lint-action
+ uses:
golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
with:
- version: v2.0.2
+ version: v2.8.0
args: --timeout=10m
Review Comment:
this kept failing in CI, so i updated it to match iceberg-go
https://github.com/apache/iceberg-go/blob/f3b406da279fe765afd535493f7127edf13aec3a/.github/workflows/go-ci.yml#L53-L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
