ebyhr commented on code in PR #15977:
URL: https://github.com/apache/iceberg/pull/15977#discussion_r3097045894


##########
api/src/main/java/org/apache/iceberg/expressions/Literals.java:
##########
@@ -747,4 +752,50 @@ public String toString() {
       return "X'" + BASE16_ENCODING.encode(bytes) + "'";
     }
   }
+
+  /**
+   * A sentinel literal representing an explicit null default value. This is 
distinct from a Java
+   * {@code null} literal reference, which means "not set." Engines use this 
distinction to decide

Review Comment:
   ```suggestion
      * {@code null} literal reference, which means "not set". Engines use this 
distinction to decide
   ```



##########
api/src/main/java/org/apache/iceberg/expressions/Literal.java:
##########
@@ -71,6 +71,18 @@ static Literal<BigDecimal> of(BigDecimal value) {
     return new Literals.DecimalLiteral(value);
   }
 
+  /**
+   * Returns a sentinel literal representing an explicit null default value.
+   *
+   * <p>This is distinct from a Java {@code null} literal reference, which 
means "not set." When

Review Comment:
   ```suggestion
      * <p>This is distinct from a Java {@code null} literal reference, which 
means "not set". When
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to