smaheshwar-pltr commented on PR #3220: URL: https://github.com/apache/iceberg-python/pull/3220#issuecomment-4275468204
One area where we could potentially improve on the Java implementation: field ID reuse during replace currently only looks at the current schema (matching Java's `TypeUtil.assignFreshIds`), so an A→B→A replace where A and B have disjoint fields creates a 3rd schema instead of reusing schema A. We could build the name→ID map from all historical schemas instead, which would allow the dedup to find the match. This is essentially what @Fokko suggested in https://github.com/apache/iceberg-python/pull/433#discussion_r1524529502 with `union_by_name`. We chose not to diverge for now — would love community thoughts on whether this is worth pursuing as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
