xanderbailey commented on PR #2340: URL: https://github.com/apache/iceberg-rust/pull/2340#issuecomment-4283036825
> Nice work @xanderbailey, the wire format matches Java's `[0x01][Avro binary datum]` layout, and using `SensitiveBytes` for the DEK internally is a good improvement over raw `Vec<u8>`. > > Is the omission of a way to set `file_length` after construction intentional? Java has `copyWithLength(long length)` which gets called in the write path after the encrypted file is written, since you don't know the length up front. Might be worth adding a way to set this field (builder method, `with_file_length`, etc.) if the write path will need it downstream. Yes left this off semi intentionally for now since it's an optimisation I didn't handle in my POC. Happy to add this though! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
