xanderbailey commented on PR #2339: URL: https://github.com/apache/iceberg-rust/pull/2339#issuecomment-4283623902
> Thanks @xanderbailey, the trait design is clean and the `InMemoryKeyManagementClient` is a solid test utility. > > One minor nit: the `key_size` field on `InMemoryKeyManagementClient` controls the size of randomly generated _master_ keys, but could be misread as controlling wrap/unwrap behavior. Since this is a testing utility that people will read as example code, something like `master_key_size` might be clearer about what it governs. [60989d2](https://github.com/apache/iceberg-rust/pull/2339/commits/60989d2892e86e994ef28633da09ba60d0a300c5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
