huaxingao commented on code in PR #15994: URL: https://github.com/apache/iceberg/pull/15994#discussion_r3114161796
########## core/src/main/java/org/apache/iceberg/udf/UdfTypeUtil.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.udf; + +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.node.ObjectNode; +import java.io.IOException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.JsonUtil; + +/** + * Utility for reading and writing UDF types. Types can be either a primitive type string (e.g., + * "int", "string", "variant") or a JSON object for nested types (struct, list, map). + */ +class UdfTypeUtil { + + private UdfTypeUtil() {} + + /** + * Reads a UDF type from a JSON node. Returns a String for primitive types or a Map for nested + * types. + */ + static Object readType(JsonNode node) { + Preconditions.checkArgument(node != null, "Cannot read type from null node"); + + if (node.isTextual()) { + return node.asText(); + } else if (node.isObject()) { + return JsonUtil.mapper().convertValue(node, java.util.Map.class); Review Comment: I think it's safer now with the new `UdfType` ########## core/src/main/java/org/apache/iceberg/udf/UnknownUdfRepresentation.java: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.udf; + +import org.immutables.value.Value; + [email protected] +public interface UnknownUdfRepresentation extends UdfRepresentation {} Review Comment: Yes. A definition version can have multiple representations but only some are understood by the library. When deserializing, if the library encounters a type it doesn't recognize, it stores it as `UnknownUdfRepresentation` instead of throwing. I have change this to private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
