xanderbailey commented on code in PR #2351:
URL: https://github.com/apache/iceberg-rust/pull/2351#discussion_r3115994830
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -1509,6 +1512,36 @@ fn project_column(
}
}
+fn compute_is_nan(array: &ArrayRef) -> std::result::Result<BooleanArray,
ArrowError> {
+ // Compute NaN over the contiguous values slice, then fold the null bitmap
+ // in with a single bitwise AND so that null slots become false.
+ // Per the Iceberg spec, is_nan is non-null-propagating: NULL → false.
+ let (values, nulls) = match array.data_type() {
+ DataType::Float32 => {
+ let arr = array.as_primitive::<Float32Type>();
+ (
+ BooleanBuffer::from_iter(arr.values().iter().map(|v|
v.is_nan())),
+ arr.nulls(),
+ )
+ }
+ DataType::Float64 => {
+ let arr = array.as_primitive::<Float64Type>();
+ (
+ BooleanBuffer::from_iter(arr.values().iter().map(|v|
v.is_nan())),
+ arr.nulls(),
+ )
+ }
+ _ => unreachable!("is_nan is only valid for float types"),
+ };
+
+ let values = match nulls {
+ Some(nulls) => &values & nulls.inner(),
Review Comment:
nulls.inner() is an "is not null" mask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
