xixipi-lining commented on PR #925: URL: https://github.com/apache/iceberg-go/pull/925#issuecomment-4303024237
Hi @zeroshade @laskoviymishka , thanks for the reviews. I’ve updated the PR to address your feedback: 1. Data Writing Tests: Added TestMultiTableTransactionWriteData to verify that multi-table transactions work correctly with actual data appends. 2. Phase 2 Conflict Verification: Added TestCommitTransactionDeterministicRollback using a mockFS to simulate conflicts during the commit phase, ensuring DB atomicity. 3. Non-SQLite Testing & Deadlocks: I’ve added identifier sorting to ensure a deterministic locking order and prevent deadlocks in row-level locking DBs (like Postgres/MySQL). 4. Error Handling: Added catalog.ErrCommitFailed to provide a consistent error contract across backends, aligning with Java/Python implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
