mxm commented on code in PR #15996: URL: https://github.com/apache/iceberg/pull/15996#discussion_r3131015045
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/IndexCommand.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.util.List; +import org.apache.flink.annotation.Internal; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +/** + * Command from the {@link EqualityConvertPlanner} to the {@link EqualityConvertWorker}. + * + * <p>{@link Type#ADD_DATA_ROW} adds a row from a data file to the worker's PK index shard. {@link + * Type#RESOLVE_DELETE} resolves an equality delete key against the index and emits {@link + * DVPosition}s for all matching rows. + * + * <p>Fields are non-final and a no-arg constructor is provided to satisfy Flink's POJO type + * requirements, enabling efficient POJO serialization instead of Kryo. Use the static factory + * methods to construct instances. + */ +@Internal +public class IndexCommand { + + public enum Type { + ADD_DATA_ROW, + RESOLVE_DELETE + } + + private Type type; + private Long mainSnapshotId; Review Comment: Using primitive type now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
