mxm commented on code in PR #15865:
URL: https://github.com/apache/iceberg/pull/15865#discussion_r3131651613
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/RewriteDataFiles.java:
##########
@@ -232,6 +234,20 @@ public Builder branch(String newBranch) {
return this;
}
+ /**
+ * Configures a dynamic time-based filter for rewriting. Only data files
within the specified
+ * lookback duration from the current time will be considered for
rewriting.
+ *
+ * @param newPartitionTimeColumn the name of the partition time column in
the table schema
+ * @param newRewriteLookback the lookback duration from the current time
+ * @return this for method chaining
+ */
+ public Builder rewriteLookback(String newPartitionTimeColumn, Duration
newRewriteLookback) {
Review Comment:
Could we let the filter by dynamic? For example:
```java
public Builder filter(Supplier<Expression> filterSupplier) {
this.filterSupplier = filterSupplier;
return this;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
