nssalian opened a new pull request, #16087:
URL: https://github.com/apache/iceberg/pull/16087

   Fixes: #14707 
   ## Summary                                                                   
                                                                      
                                                                                
              
   - Override `variant()` in `VectorizedReaderBuilder` to handle variant 
columns gracefully instead of crashing with "Not implemented for variant"    
   - Add MERGE INTO test for tables with variant columns                        
                                                          
   
   ## Changes                                                                   
                                                                      
   
   The fix is the same as `struct()`, which already throws 
`UnsupportedOperationException` for unsupported types.
   Vectorized read support for Variant is going to need more work.
                                                                                
                                             
   ## Test plan                                                                 
                                                                      
                     
     - Added a MERGE INTO test as per the example in the issue 
`TestSparkVariantRead.testMergeIntoWithVariant` - MERGE INTO with variant 
columns, parameterized for both `vectorized=true` and `vectorized=false`
     - Verified the test crashes without the fix (`vectorized=true` hits the 
unimplemented `variant()`)        
   ```
   Caused by: java.lang.UnsupportedOperationException: Not implemented for 
variant
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to