rdblue commented on code in PR #16043: URL: https://github.com/apache/iceberg/pull/16043#discussion_r3132424000
########## spark/v4.0/spark-runtime/LICENSE: ########## @@ -207,71 +207,71 @@ This binary artifact contains Apache Avro. Copyright: Copyright 2010-2019 The Apache Software Foundation Home page: https://avro.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 +License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt -------------------------------------------------------------------------------- This binary artifact contains the Jackson JSON processor. Copyright: 2007-2019 Tatu Saloranta and other contributors Home page: http://jackson.codehaus.org/ -License: http://www.apache.org/licenses/LICENSE-2.0.txt +License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt -------------------------------------------------------------------------------- This binary artifact contains Apache Parquet. Copyright: 2014-2024 The Apache Software Foundation Home page: https://parquet.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 +License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt Review Comment: These changes are unnecessary and shouldn't be included here. We can talk about whether to have more information on this line, but it isn't related to the purpose of this PR, which is to update the files for correctness. Including unnecessary changes increases what needs to be reviewed (or in this case scrolled past) and that can cause things to be missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
