rdblue commented on a change in pull request #1873:
URL: https://github.com/apache/iceberg/pull/1873#discussion_r536253250
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -96,7 +115,14 @@ protected HiveTableOperations(Configuration conf,
HiveClientPool metaClients, Fi
this.database = database;
this.tableName = table;
this.lockAcquireTimeout =
- conf.getLong(HIVE_ACQUIRE_LOCK_STATE_TIMEOUT_MS,
HIVE_ACQUIRE_LOCK_STATE_TIMEOUT_MS_DEFAULT);
+ conf.getLong(HIVE_ACQUIRE_LOCK_TIMEOUT_MS,
HIVE_ACQUIRE_LOCK_TIMEOUT_MS_DEFAULT);
+ this.lockCheckMinWaitTime =
+ conf.getLong(HIVE_LOCK_CHECK_MIN_WAIT_MS,
HIVE_LOCK_CHECK_MIN_WAIT_MS_DEFAULT);
+ this.lockCheckMaxWaitTime =
+ conf.getLong(HIVE_LOCK_CHECK_MAX_WAIT_MS,
HIVE_LOCK_CHECK_MAX_WAIT_MS_DEFAULT);
+ this.lockCheckBackoffScaleFactor =
+ conf.getDouble(HIVE_LOCK_CHECK_BACKOFF_SCALE_FACTOR,
HIVE_LOCK_CHECK_BACKOFF_SCALE_FACTOR_DEFAULT);
Review comment:
We don't expose the scale factor in other places. I think it makes sense
to keep it simple and not have one here either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
