huaxingao commented on code in PR #15975:
URL: https://github.com/apache/iceberg/pull/15975#discussion_r3132881012
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -310,8 +310,12 @@ private Result rebuildMetadata() {
// rebuild manifest files
Set<ManifestFile> metaFiles = rewriteManifestListResult.toRewrite();
+ // For full copy (no start version), pass null so all live entries are
included
+ // in the copy plan. Current snapshot IDs may not cover entries whose
original
+ // adding snapshot has been expired, but those files can still be live.
+ Set<Snapshot> snapshotFilter = startMetadata == null ? null :
deltaSnapshots;
Review Comment:
Yes, `filter` is misleading here. Renamed to `deltaSnapshotIds`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
