bharos commented on code in PR #15902:
URL: https://github.com/apache/iceberg/pull/15902#discussion_r3133328428
##########
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java:
##########
@@ -462,6 +464,43 @@ public <T> Boolean notIn(BoundReference<T> ref, Set<T>
literalSet) {
@Override
public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
+ int id = ref.fieldId();
+ if (isNestedColumn(id)) {
+ return ROWS_MIGHT_NOT_MATCH;
+ }
+
+ if (canContainNulls(id)) {
+ return ROWS_MIGHT_NOT_MATCH;
+ }
+
+ String prefix = (String) lit.value();
Review Comment:
Thanks @RussellSpitzer
Moved to inside the bounds check branch.
Also added couple of additional tests similar to
https://github.com/apache/iceberg/pull/15883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
